Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model card previews #873

Merged
merged 6 commits into from
Oct 1, 2024
Merged

Model card previews #873

merged 6 commits into from
Oct 1, 2024

Conversation

rahulkgupta
Copy link
Collaborator

@rahulkgupta rahulkgupta commented Sep 19, 2024 •
edited
Loading

  • assets now reads from catalog.json and will create mixins from there.
  • catalog.json values contains a src field which is used for both glb and images.

todo

  • remove images from here.

@rahulkgupta rahulkgupta mentioned this pull request Sep 19, 2024
Open
@rahulkgupta rahulkgupta marked this pull request as ready for review September 30, 2024 19:55
@kfarr kfarr merged commit d65a0e0 into main Oct 1, 2024
1 check passed
@kfarr kfarr deleted the model-card-previews branch October 1, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentfretin vincentfretin vincentfretin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rahulkgupta @vincentfretin @kfarr